fix: silence build warnings in hash join and pipeline task#971
Merged
Conversation
Lower the cudf filtered_join version guard to 26.6, where the constructor without the deprecated set_as_build_table parameter is already available, so the non-deprecated path is compiled instead of the deprecated one. Explicitly discard the nodiscard push() result in the convertible_gpu_pipeline_task destructor; ignoring a failed push during queue shutdown is intentional. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bwyogatama
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower the cudf
filtered_joinversion guard to26.6, where the constructor without the deprecatedset_as_build_tableparameter is already available, so the non-deprecated path is compiled instead of the deprecated one.Explicitly discard the
nodiscardpush()result in theconvertible_gpu_pipeline_taskdestructor; ignoring a failed push during queue shutdown is intentional.